fix: Widget disposal correctly now redirects focus#240
Closed
BenHenning wants to merge 1 commit intoRaspberryPiFoundation:mainfrom
Closed
fix: Widget disposal correctly now redirects focus#240BenHenning wants to merge 1 commit intoRaspberryPiFoundation:mainfrom
BenHenning wants to merge 1 commit intoRaspberryPiFoundation:mainfrom
Conversation
WorkspaceSvg.markFocused() only needs to be overwritten in behavior specifically when closing a widget, not always (to avoid breaking other Blockly behaviors).
Contributor
|
I realise this is in draft, but we took a look while trying to understand everything that might impact user testing. At the moment:
|
Collaborator
Author
|
Replaced by #326. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136
Fixes #222
TODO: Fill in description.